cognoma / frontend

Frontend for Project Cognoma
http://cognoma.org/
Other
4 stars 22 forks source link

Bugfix/131 #134

Closed ramenhog closed 6 years ago

ramenhog commented 6 years ago

Issue Number

131

Purpose/Implementation Notes

Create a custom component for notifications to fix the look and functionality of the previous Angular Growl ones

Apparently $scope.$apply is necessary for emitted events in Angular: https://stackoverflow.com/questions/22414017/angularjs-why-am-i-needing-scope-apply-within-scope-on

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Functional tests

Checklist

Put an x in the boxes that apply.

Screenshots

screen shot 2018-02-07 at 3 24 49 pm screen shot 2018-02-07 at 3 25 21 pm

ramenhog commented 6 years ago

@mhuyck Should be ready for re-review. Thanks!

ramenhog commented 6 years ago

Changed the param to isAutoDismiss. I agree it makes a lot more sense this way.