Closed ramenhog closed 6 years ago
Create a custom component for notifications to fix the look and functionality of the previous Angular Growl ones
Apparently $scope.$apply is necessary for emitted events in Angular: https://stackoverflow.com/questions/22414017/angularjs-why-am-i-needing-scope-apply-within-scope-on
$scope.$apply
What types of changes does your code introduce? Put an x in the boxes that apply
x
Put an x in the boxes that apply.
@mhuyck Should be ready for re-review. Thanks!
Changed the param to isAutoDismiss. I agree it makes a lot more sense this way.
isAutoDismiss
Issue Number
131
Purpose/Implementation Notes
Create a custom component for notifications to fix the look and functionality of the previous Angular Growl ones
Apparently
$scope.$apply
is necessary for emitted events in Angular: https://stackoverflow.com/questions/22414017/angularjs-why-am-i-needing-scope-apply-within-scope-onTypes of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyFunctional tests
x
on the right or is automatically dismissed after 5 secondsChecklist
Put an
x
in the boxes that apply.Screenshots