show all diseases and load calculated pos/negs as they are calculated - Githubissues

cognoma / frontend

Frontend for Project Cognoma

http://cognoma.org/

Other

4 stars 22 forks source link

show all diseases and load calculated pos/negs as they are calculated #141

Closed ramenhog closed 6 years ago

ramenhog commented 6 years ago

Issue Number

Closes #111

Purpose/Implementation Notes

loads all 33 diseases before calculations are completed

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

all 33 diseases are immediately loaded in table before calculates complete
while calculations are running, show loading icon
once calculation finishes, show calculation and hide loading icon

Checklist

Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Screenshots

pr-141

ramenhog commented 6 years ago

@mhuyck should be ready for re-review! Thanks!

ramenhog commented 6 years ago

🎉 Thanks @mhuyck !