cognoma / frontend

Frontend for Project Cognoma

http://cognoma.org/

Other

4 stars 22 forks source link

Test/add cg table test #148

Closed ramenhog closed 6 years ago

ramenhog commented 6 years ago

Issue Number

69

Purpose/Implementation Notes

Add unit tests for cgTable:

displays correct number of columns based on column config
displays correct number of rows based on data passed into component
can detect if all results are selected
properly selects all results
properly unselects all results
sets sort variables correctly when sorting is called

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

tests pass locally

Checklist

Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

ramenhog commented 6 years ago

@mhuyck nice catches! Just fixed them and this is ready for re-review, thanks! 👍