cognoma / frontend

Frontend for Project Cognoma

http://cognoma.org/

Other

4 stars 22 forks source link

Bugfix/removing wrong param fix #154

Closed ramenhog closed 6 years ago

ramenhog commented 6 years ago

Issue Number

147

Purpose/Implementation Notes

Removing a param on the non-active tab does not delete from the currently active tab params

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

Removing a param on the non-active tab in sidebar does not delete from the currently active tab params
Removing a param on the active tab deletes the appropriate param
Mass removing params via checkboxes removes the selected params

Checklist

Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

ramenhog commented 6 years ago

@mhuyck got away from that 🦆 typing 👍. This is good for re-review, thanks!