cognoma / frontend

Frontend for Project Cognoma

http://cognoma.org/

Other

4 stars 22 forks source link

disable button while calculating and show main loading indicator #155

Closed ramenhog closed 6 years ago

ramenhog commented 6 years ago

Issue Number

152

Purpose/Implementation Notes

Submit query button is now disabled until the sample calculations are completed for all disease listings
show a main disease type tab loading indicator
add tests for this bug

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

while sample calculations are underway, the submit query button is disabled
when calculations are complete (and both mutations and disease types have been added to query), the submit query button is enabled

Checklist

Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules