cognoma / frontend

Frontend for Project Cognoma
http://cognoma.org/
Other
4 stars 22 forks source link

change query to use any_mutations with comma separated list #164

Closed ramenhog closed 6 years ago

ramenhog commented 6 years ago

Issue Number

Closes #160

Purpose/Implementation Notes

Change the frontend to use the any_mutations filter to get correct union for multiple input query genes

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Functional tests

Make sure the math adds up. Used @cgreene 's test case in #160:

Just KRAS: screen shot 2018-04-02 at 3 45 14 pm

Just PIK3CA: screen shot 2018-04-02 at 3 45 00 pm

Together: screen shot 2018-04-02 at 3 45 32 pm

cgreene commented 6 years ago

You probably noticed, but the tests appear to be unhappy. Perhaps one of them relied on the old behavior.

ramenhog commented 6 years ago

Hmm, weird, the tests are passing locally 🤔

ramenhog commented 6 years ago

Tests on previously succeeding branches like master all seem to be failing now even though no code was changed. Going to ignore the 3 tests that seem to be causing it for now and fix them in a future branch.

cgreene commented 6 years ago

@ramenhog approach seems reasonable to me at this point 👍