change mutation service to use an angular promise so scope will be applied

ramenhog commented 6 years ago

Issue Number

Closes #162

Purpose/Implementation Notes

Apparently, the mutation service was using a JS promise instead of using $q to create a promise. Therefore scope was not being applied/updated to set isSearching to false even though search results had been returned.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

UI doesn't get stuck searching after results have already been returned

ramenhog commented 6 years ago

@mhuyck Replaced the non-angular Promise in UserAuth.js with $q as well and deleted some components/files we aren't using. Should be good now 👍

mhuyck commented 6 years ago

Awesome. Hooray for rooting out dead code! 🙌

Looks great.

cognoma / frontend