Adds CircleCI env vars for Karma and Protractor test

[bdolly]

Adds unit tests for on_config.js to test angular ui-router states and routes

[bdolly]

@awm33 I added the CircleCI vars to the karma and protractor configs but couldn't find a var to use for the JOB_NUMBER. The testing setup was originally configured to use Travis and the env vars for that so I just converted them over to CircleCI. The process.env.TRAVIS_JOB_NUMBER was used to set the tunnelIdentifier property for SauceLabs integration but didn't see an equilvalent for CircleCI env vars .

[awm33]

@bdolly You could try using CIRCLE_SHA1 as a build identifier

[bdolly]

@awm33 looks like this PR CirlceCI check failed due to the fact that we don't have a SauceLabs account and it's trying to launch and run test through SauceLabs. I am unfamiliar with SauceLabs, do you think it's something necessary for our CI testing or is it just another CI runner?

[cgreene]

I have a saucelabs account for open source projects if we want to use it. Happy to hook it up if it's desired.

On Tue, Nov 1, 2016 at 11:26 AM bdolly notifications@github.com wrote:

@awm33 https://github.com/awm33 looks like this PR CirlceCI check failed due to the fact that we don't have a SauceLabs https://saucelabs.com/Baccount and it's trying to launch and run test through SauceLabs. I am unfamiliar with SauceLabs, do you think it's something necessary for our CI testing or is it just another CI runner?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cognoma/frontend/pull/36#issuecomment-257596550, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhHs1nnaFFel-Dy7-dYLM_qoqdXnM-Cks5q51oXgaJpZM4KhcnU .

[bdolly]

@cgreene can you explain what the difference between CircleCI and SauceLabs is as I'm new to the world of CI testing? Is SauceLabs a cross browser testing platform for CI similar to BrowserStack?

[cgreene]

I wasn't previously familiar with BrowserStack. From a quick glance at their page they seem to be offering a similar service to what SauceLabs offers.

On Tue, Nov 1, 2016 at 11:39 AM bdolly notifications@github.com wrote:

@cgreene https://github.com/cgreene can you explain what the difference between CircleCI and SauceLabs is as I'm new to the world of CI testing? Is SauceLabs a cross browser testing platform for CI similar to BrowserStack?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/cognoma/frontend/pull/36#issuecomment-257600437, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhHs89ftiu7gA7lADdcC2tibE2sBGy2ks5q510egaJpZM4KhcnU .

[bdolly]

@cgreene ok cool I thought they were similar. If you want to hook SauceLabs up to the front-end cI stuff I don't see how it would hurt to have more test coverage.

Let me know if there's anything I need to adjust in the proctractor or karma configs for it, looks like it's set using sauceUser: process.env.SAUCE_USERNAME, sauceKey: process.env.SAUCE_ACCESS_KEY

[dhimmel]

@dhimmel not sure how to resolve these conflicts, I followed the command line instructions with no luck

@bdolly I got an email with the above comment. Did you resolve the conflicts? It doesn't look like there are any outstanding conflicts according to GitHub.

[bdolly]

@dhimmel yeah figured it out shortly after I posted it up. Waiting until we have the cirlceCI stuff working properly before I merge this

[bdolly]

@cgreene could we get saucelabs hooked up soon so we can merge this in?

[cgreene]

@bdolly : SAUCE_USERNAME and SAUCE_ACCESS_KEY environment variables are set.

[cgreene]

@bdolly : a couple issues here with SauceLabs SauceConnect - their "latest" build is a couple years out of date. They have blamed this for issues with CircleCI in the past: https://support.saucelabs.com/customer/portal/questions/15881491-error-failed-to-bring-up-tunnel-vm-intermittently

I switched to their latest version 4.4.1 and I still have issues setting up the tunnel from CircleCI. I have filed a ticket about both the out of date version and the remaining difficulties connecting from CircleCI. The changes to circle.yml to setup the tunnel are incomplete as I wait for their reply.

[bdolly]

@dhimmel last CI build passed I think we're good to merge this PR whenever you give it your nod of approval

[dhimmel]

@dhimmel last CI build passed I think we're good to merge this PR whenever you give it your nod of approval

Nod. FYI, no need for my approval. As long as there is an approval from any project member.