search

cognoma / machine-learning

Machine learning for Project Cognoma
Other
32 stars 47 forks source link

Update Vega plot in notebook #99

Closed patrick-miller closed 7 years ago

patrick-miller commented 7 years ago

So far this PR has made it so the Vega plot doesn't save intermediate files.

I am exploring how to work https://github.com/altair-viz/jupyter_vega into the notebook. I think that will make the plots dynamic in a pre-run notebook.

dhimmel commented 7 years ago

@patrick-miller before I merge just wanted to make you aware of this GitHub warning:

Unrecognized author. If this is you, make sure patrick.miller@macmillan.com is associated with your account. Click to add email addresses in your account settings.

In short, patrick.miller@macmillan.com isn't associated with your GitHub account. This means the commit will not be associated with your github account. The solution is to:

  1. either add patrick.miller@macmillan.com as an additional email on GitHub
  2. modify your commits to use the email address registered with github or patrick-miller@users.noreply.github.com. If using this option, you might as well squash everything, then just change authorship of that one commit.
patrick-miller commented 7 years ago

I'll squash everything and change authorship for the commit.

dhimmel commented 7 years ago

2.TCGA-MLexample-covariates.py should be in scripts. Will address later.