search

cogu / autosar

A set of python modules for working with AUTOSAR XML files
MIT License
380 stars 165 forks source link

0.5.2: Type hint for make_packages should be "*refs: str" #102

Closed qg020 closed 6 months ago

qg020 commented 7 months ago

Hi all, great package - thank you!

I am updating a script that was at 0.4 with PyCharm. The make_packages call takes a comma separated list of package name strings but the type hint in the function definition says '*refs: list[str]'. This causes PyCharm to flag the call with a warning since I am not passing a list of strings but the comma separated strings themselves.

Let me know if you'd like me to make a pull request with this change.

Thank you.

cogu commented 7 months ago

Thanks for finding the issue, I will fix it soon.

cogu commented 6 months ago

Fixed in v0.5.3. Actually, I now recommend that you use the new method Workspace.create_package_map instead. It internally calls make_packages. I've updated all the example code and documentation to use the new method.