search

cogu / autosar

A set of python modules for working with AUTOSAR XML files
MIT License
381 stars 165 forks source link

Write data element description attribute to XML #52

Closed SHolzmann closed 4 years ago

cogu commented 4 years ago

Why does this pull-request have 3 commits? Did you allow git to do an automatic merge commit before you updated your local master branch? You can do advanced git rebase to rewrite your commit history but in your case I think it's better that you create a new feature branch based on my latest master and then cherry-pick commit 63e18ee (description update in XML writer) as a new commit on the new feature branch.

I will not accept this pull-request in its current state when it contains 3 commits but I do approve of the change you did to writer_base.py

SHolzmann commented 4 years ago

Okay, I will fix the pull request.