search

cogumm / shellinabox

Exported from code.google.com/p/shellinabox
Other
0 stars 0 forks source link

extend vt100.js to support xterm 256 colors #105

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
i really like my vim/screen/mutt/finch colors as defined by my server conf 
files. 

since vt100 emulators can support 256 colors by interpreting additional escape 
codes sent by the server, i went ahead and implemented this on my local copy of 
shellinabox.

the only changes i made were in vt100.js and some of the included css files.

with these updates, i can run screen/vim/mutt with full 256 color support as 
per the color themes on the server. the css files i changed merely provide the 
base 16 system colors as well as a default background/front-color.

perhaps others would like this feature as well?

and btw, this is a great project, thanks for your work. i learned a lot about 
terminal emulators going through your code...

Original issue reported on code.google.com by ele...@gmail.com on 2 Jan 2011 at 8:15

Attachments:

GoogleCodeExporter commented 9 years ago 
i made the same changes in color.css to styles.css as well. basically i just 
matched the 16 system colors to that of Terminal.app as found here: 
http://en.wikipedia.org/wiki/Ansi_escape_codes#Colors

Original comment by ele...@gmail.com on 2 Jan 2011 at 8:18

GoogleCodeExporter commented 9 years ago 
attaching newer vt100.js and styles.css, adding my changes into the version in 
trunk, rather from the tar.gz versions which are outdated compared to trunk.

Original comment by ele...@gmail.com on 3 Jan 2011 at 12:04

Attachments:

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I have tested the vt100.js/styless.css today. They work great.

Thanks!

Original comment by andy.chr...@gmail.com on 14 Jan 2011 at 7:52

GoogleCodeExporter commented 9 years ago 
These patches are great. There still a few things that need to be improved, 
though.

* The bgAnsi* classes in your color.css are setting 'color' when they should be 
setting 'background-color'.

* An off-by-one error in two places in vt100.js is preventing ansi0 and bgAnsi0 
from being used at all.

* A logic error in vt100.js is causing it to incorrectly set the foreground 
color to ansi7 for text which has the default color + bright attribute.

* When setting text to bold, you used "text-weight:bold;". It should be 
"font-weight:bold;"

I have fixed all of the above, and attached the updated files.

Original comment by hinrik....@gmail.com on 29 Nov 2011 at 11:58

Attachments:

GoogleCodeExporter commented 9 years ago 
Please provide a patch file instead of individual files.

Original comment by beewoo...@gmail.com on 31 Mar 2012 at 10:18

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Would like to add that this is a highly anticipated feature - I had installed 
Shellinabox but removed it because irssi became unusable.

Original comment by peng...@gmail.com on 30 Nov 2012 at 4:31

GoogleCodeExporter commented 9 years ago 
I've implemented this different way... What about ESC]4 ? we need to be able to 
alter the array of colors. This requires change in doControl's logic. not 
sharing vt100.js because of mixed style

Original comment by onlylog...@gmail.com on 4 May 2013 at 9:23

GoogleCodeExporter commented 9 years ago 
ESC]4 wouldn't follow the standard for control sequence (because it ends with 4)
and would be nuisance to deal with in applications.

Original comment by dic...@his.com on 4 May 2013 at 11:32

GoogleCodeExporter commented 9 years ago 
I would really love to see this in the main repository. Any chance of that 
happening soon? It's the only thing preventing us from using it in out VPN 
portal.

Original comment by callan.bryant@gmail.com on 2 Jun 2013 at 8:27

GoogleCodeExporter commented 9 years ago 
The best way to see your change integrated is to pull the repository, make your 
change and send me a pull request.

Original comment by beewoo...@gmail.com on 3 Jun 2013 at 4:47

GoogleCodeExporter commented 9 years ago 
Please please please someone add the 256 color support. :D

Original comment by TruSktr on 16 Sep 2013 at 2:07

GoogleCodeExporter commented 9 years ago 
Lots of people know how to edit javascript files, but not all know how to 
create patches. As such, why don't you (project members) just make the patch 
using the suggested files?

Original comment by TruSktr on 16 Sep 2013 at 2:08

GoogleCodeExporter commented 9 years ago 
Hi, we have 256 color support added in our maintained fork. I think it works ok 
:)

Please see: https://github.com/shellinabox/shellinabox

Original comment by luka.kra...@gmail.com on 19 Mar 2015 at 10:17