search

cohaolain / ryanair-py

This is an open source Python module which allows you to retrieve the cheapest flights, with or without return flights, within a given set of dates.
https://github.com/cohaolain/ryanair-py
MIT License
51 stars 15 forks source link

Logging problem #4

Closed dolohow closed 1 year ago

dolohow commented 1 year ago

I believe you should not set handler and level of logging, otherwise I cannot reconfigure it.

For example, I would like to log into a file and I can't with this simple code

logging.basicConfig(filename='loty.log', format='%(asctime)s %(message)s', level=logging.INFO)

Probably I could do it differently, however library should not configure logger at all I think.

cohaolain commented 1 year ago

This is worth looking into, I agree.

cohaolain commented 1 year ago

Hope this merge solves your issue, will include in the next release. Let me know if you wish to re-open.