search

cohenjo / pg_idx_advisor

A PostgreSQL extension to analyze queries and give indexing advice.
50 stars 8 forks source link

fixes a couple of issues #3

Closed JerrySievert closed 9 years ago

JerrySievert commented 9 years ago

issue 1, T_GroupingFunc was released in 9.4, not 9.5. this fixes the #ifdef

issue 2, this fixes loading of the extension when calling create extension pg_idx_advisor

cohenjo commented 9 years ago

Hi, Thanks. I'll merge this in later tonight when I'll have a little time. Note: the load should not be part of the extension as it is per session - we don't want it to run always as it is quite heavy. every session that want's advice will need the load - maybe I should wrap it in a function or something? (I'll need to check if PG supports this...)

I'll merge the first 2 commits. Regards,

cohenjo commented 9 years ago

Merged first 2 commits. I left the plugin to be loaded at each session as it's session based (and we don't want/need to create the extension each time...)

Thanks,