search

cohere-ai / cohere-python

Python Library for Accessing the Cohere API
https://docs.cohere.ai
MIT License
283 stars 62 forks source link

rerank (async client) does not have parameter return_documents #339

Open cirezd opened 10 months ago

cirezd commented 10 months ago

https://github.com/cohere-ai/cohere-python/blob/5e9e872cd75ebea3c2091dd043b875b494f21535/cohere/client_async.py#L495C33-L495C38

Hello, the reranker (async client) does not have parameter return_documents. It is hard-coded to False in the code above.

murdadesmaeeli commented 9 months ago

Hi @cirezd, you might be right in that there might not be a specific reason for this hard coding. @mkozakov , @lfayoux can you confirm?

If there is no specific reason then this could be fixed with a simple PR.