cohere-ai / notebooks

Code examples and jupyter notebooks for the Cohere Platform
MIT License
451 stars 120 forks source link

RAG Guide: Comment out set_css logic that breaks for Jupyter notebooks #161

Closed rossdanlm closed 4 months ago

rossdanlm commented 4 months ago

RAG Guide: Comment out set_css logic that breaks for Jupyter notebooks

I noticed that this was breaking for when I was running this in Jupyter notebooks. I also noticed we had comments in the notebook saying # Uncomment for Google Colab to ... so figured we could do the same here. If you don't like it, no worries

Test Plan

Before it wasn't working, and we got these errors

Error in callback <function set_css at 0x33e33d260> (for pre_run_cell), with arguments args (<ExecutionInfo object at 33e35b110, raw_cell="raw_documents = [
    {
        "title": "Text Emb.." store_history=True silent=False shell_futures=True cell_id=vscode-notebook-cell:/Users/rossdancraig/Projects/cohere-notebooks/notebooks/guides/RAG_with_Chat_Embed_and_Rerank_via_Pinecone.ipynb#X13sZmlsZQ%3D%3D>,),kwargs {}:
{
    "name": "TypeError",
    "message": "set_css() takes 0 positional arguments but 1 was given",
    "stack": "---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
TypeError: set_css() takes 0 positional arguments but 1 was given"
}

Now it works!


Stack created with Sapling. Best reviewed with ReviewStack.

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rossdan Craig rossdan@lastmileai.dev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

mrmer1 commented 4 months ago

@rossdanlm Thanks for highlighting this! Merging.