search

cohere-coop / nourish.party

Celebrating and nourishing creative communities
Other
6 stars 0 forks source link

Calculate test coverage with Coveralls #52

Closed bhaibel closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling afe6dc91d2e1927afc5c5b275a6c1cfcbf778269 on bh-add-coveralls-support into on primary.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling e0d87aa5a1808ee81b76f82787ae4dcddb3edce5 on bh-add-coveralls-support into on primary.

zspencer commented 6 years ago

@bhaibel - maybe-blocking - are we supposed to be checking in the coverage folder? It doesn't look like it's checked in in the coveralls-ruby repo; which I assume is the canonical setup: https://github.com/lemurheavy/coveralls-ruby

But I haven't used coveralls before so I don't really know.

bhaibel commented 6 years ago

coveralls hooks into Travis automagically and therefore shouldn't need to have a checked-in coverage directory -- I think the gem is forwarding a coverage report that's generated as a build artifact on CI runs?

Gonna hold off on merging until you ack this so that you can figure out if you're okay with that approach.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling e90404347916de07ed093f29e8b412093eb372fc on bh-add-coveralls-support into on primary.