Add some design shiny to existing pages

bhaibel commented 6 years ago

create two page template layouts appropriate to current content
play with colors some
introduce the Atomic Design set of formalisms
copy Devise scaffold views into developer-space
get both Devise scaffold views and existing other forms into the same markup world. (Played with using a form builder for this but I don't think we know enough yet to get the correct abstractions in place -- punting on that until we do.)

I care a bunch about the code structures we're putting in place to serve the design elements, and about the Atomic Design pattern -- I'm happy to talk in more detail about why I think these are good choices. I care a bit about label-on-top form elements (as opposed to label-to-the-left ones) because they tend to be more maintainable CSS-wise and UX research shows that they are often more usable.

I do not care much, if at all about the fonts and colors included in this and have mostly included them so that we could have some personality to look at instead of just white-and-blue scaffolding.

coveralls commented 6 years ago

Coverage remained the same at 34.483% when pulling ebd88cc6e53f6cd597d4871e38c015f23395e3c4 on bh-get-forms-into-a-design-system into 88be06c4d77c65420da953a155bbe9839d61b07f on primary.

coveralls commented 6 years ago

Coverage decreased (-8.5%) to 62.069% when pulling fe5f731746d5c24f0124112b0618061ce7e35fe7 on bh-get-forms-into-a-design-system into ebd7a6736bdc61c05b1a32d9f61eaef44e5e8f12 on primary.

coveralls commented 6 years ago

Coverage decreased (-8.5%) to 62.069% when pulling fe5f731746d5c24f0124112b0618061ce7e35fe7 on bh-get-forms-into-a-design-system into ebd7a6736bdc61c05b1a32d9f61eaef44e5e8f12 on primary.

bhaibel commented 6 years ago

How much do we care about the coverage decrease? I think it's not that big a deal since the only code added is form code, and because it was "in the system" anyway because it was part of Devise. I need a sanity check on that, though, especially because I think that the primary reason for coverage drop is the views for things like email confirmations that we don't have feature tests around.

zspencer commented 6 years ago

@bhaibel - Do you have any guesses why this error is happening? Is there something that needed to be committed that wasn't? Or is it a configuration issue?

zspencer commented 6 years ago

Weird, it looks like the yarn.lock file is committed, so I'm not sure why Heroku is barfing.

cohere-coop / nourish.party

Add some design shiny to existing pages #72