Closed bhaibel closed 6 years ago
How much do we care about the coverage decrease? I think it's not that big a deal since the only code added is form code, and because it was "in the system" anyway because it was part of Devise. I need a sanity check on that, though, especially because I think that the primary reason for coverage drop is the views for things like email confirmations that we don't have feature tests around.
@bhaibel - Do you have any guesses why this error is happening? Is there something that needed to be committed that wasn't? Or is it a configuration issue?
Weird, it looks like the yarn.lock file is committed, so I'm not sure why Heroku is barfing.
I care a bunch about the code structures we're putting in place to serve the design elements, and about the Atomic Design pattern -- I'm happy to talk in more detail about why I think these are good choices. I care a bit about label-on-top form elements (as opposed to label-to-the-left ones) because they tend to be more maintainable CSS-wise and UX research shows that they are often more usable.
I do not care much, if at all about the fonts and colors included in this and have mostly included them so that we could have some personality to look at instead of just white-and-blue scaffolding.