coherence-community / oracle-bedrock

Oracle Bedrock
Other
55 stars 31 forks source link

assertThat methods should take a single TimeOutConstraint #138

Closed brianoliver closed 10 years ago

brianoliver commented 10 years ago

There seems to be a proliferation of Eventually.assertThat methods, most of which requiring time-out information, which could be simplified if we provided a simple TimeoutConstraint.

Instead of writing:

Eventually.assertThat(value, matcher, 1, TimeUnit.SECOND);

we could write:

Eventually.assertThat(value, matcher, within(1, TimeUnit.SECOND));

Apart from reducing the number of timeout related methods, this would make writing timeouts more "fluent"

brianoliver commented 8 years ago

This issue was imported from JIRA ORACLETOOLS-138

brianoliver commented 10 years ago

Reported by @brianoliver

brianoliver commented 10 years ago

Marked as fixed by @brianoliver on Sunday, July 27th 2014, 7:15:42 am