search

coherence-community / oracle-bedrock

Oracle Bedrock
Other
55 stars 31 forks source link

Eventually.assertThat(...) fails to return immediately when encountering a null #202

Closed brianoliver closed 9 years ago

brianoliver commented 9 years ago

According to the contract for calling Deferred.get(), returning null is a valid object reference.

Unfortunately the Ensured class (and thus Eventually.assertThat) ignores this an will continue to retry (calling Deferred.get()) until a non-null reference is returned, or it times out.

The problem with this behavior is that a matcher expecting null will never be satisfied.

While resolving this in Oracle Tools 2.x and 3.x has no effect, it may effect custom Deferred implementations made in 1.x, as the semantics will have now changed.

brianoliver commented 8 years ago

This issue was imported from JIRA ORACLETOOLS-202

brianoliver commented 9 years ago

Reported by @brianoliver

brianoliver commented 9 years ago

Marked as fixed by @brianoliver on Friday, November 21st 2014, 1:10:14 pm