search

coherence-project / Coherence

DLNA/UPnP Media Server and Framework for the Digital Living
MIT License
171 stars 52 forks source link

twisted.web.client._parse no longer available #3

Closed gagern closed 10 years ago

gagern commented 10 years ago

coherence.upnp.core.utils.getPage makes use of twisted.web.client._parse which is no longer available in recent versions of twisted. Namely the 13.2.0 I've installed here. The function was removed in this merge but simply using the new private code instead seems like a bad idea. So I suggest you either copy and paste the old _parse function, or use something else like urlparse.urlsplit.

gagern commented 10 years ago

I've got more problems running UPnP-Inspector against my twisted install. Next one is the fact that coherence.upnp.core.utils.HeaderAwareHTTPClientFactory does not call the __init__ implementation of its super class. As a consequence, its instances lack a _disconnectedDeferred attribute which HTTPPageGetter.connectionLost relies on. Disabling the __init__ method in coherence solved that.

htgoebel commented 10 years ago

If would be great if you could submit a pull-request.

Hypfer commented 10 years ago

Fixed.

htgoebel commented 10 years ago

@Hypfer: fixed where?

Hypfer commented 10 years ago

Fixed with https://github.com/coherence-project/Coherence/pull/6

At least the twisted.web.client._parse use.

-> Partly fixed O:)

gagern commented 10 years ago

There is one occurrence of _parse left, even though one occurrence got removed.

Hypfer commented 10 years ago

Partly partly fixed.

htgoebel commented 10 years ago

Fixed.