cohesity / ansible-collection

This repository provides an Ansible collection and related modules for Cohesity DataPlatform.
GNU General Public License v3.0
3 stars 6 forks source link

cohesity_oracle_source should not require database credentials due to OS authentication is an option #20

Closed amhaats1 closed 1 year ago

amhaats1 commented 1 year ago

📚 Documentation

The documentation states a db username and password have to be specified but in the GUI if you want OS Authentication it doesn't require credentials

Module: cohesity_oracle_source

db_password: description:

Please update documentation and notes in the module that db_password and db_username is not required. I left these out and was still able to get the oracle source to register with OS Authentication which is what I was looking to do. Oracle_Source_registration

changed: [localhost] => (item=lx14845) => { "ansible_loop_var": "item", "changed": true, "invocation": { "module_args": { "cluster": "cluster", "db_password": "", "db_username": "", "endpoint": "lx14845", "force_register": true, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "ansible", "validate_certs": false } }, "item": "lx14845", "msg": "Registration of Cohesity Protection Source Complete" }

naveena-maplelabs commented 1 year ago

Sure @amhaats1 , will update thank you.

naveena-maplelabs commented 1 year ago

Please feel free to reopen if you face any issues

amhaats1 commented 1 year ago

You updated only applicable when state is present but it shouldn't be required if the user is wanting to set the source as OS authentication instead of DB authentication.
Example: which works to set the source as OS authentication

naveena-maplelabs commented 1 year ago

https://github.com/cohesity/ansible-collection/blob/main/docs/modules/cohesity_oracle_source.rst It's optional parameter only. db_password (optional, str, None) Specifies the password to access the target source database.

This parameter will not be logged.

Applicable only when state is set to present.

db_username (optional, str, None) Specifies username to access the target source database.

Applicable only when state is set to present.