search

cohesity / management-sdk-python

Cohesity Management SDK for Python.
Apache License 2.0
21 stars 20 forks source link

Feature/make http request timeout configurable #51

Closed nick6655 closed 3 years ago

nick6655 commented 3 years ago

I read over the contributors guide and am hoping I understand correctly that for minor changes like this I can propose the feature in the form of a pull request which would implement it.

The feature I am proposing is to expose the timeout via the Configuration class in a similar fashion to skip_ssl_verification. This will help to alleviate an issue I am experiencing with latency between data centers causing timeout errors. The ability to configure this value I believe should be universally helpful.

nick6655 commented 3 years ago

Thanks @pyashish I noticed the workflow which I assume is GitHub runners or something of the like still needs to be approved a run. Not sure if that's something the maintainers of the project typically do or something that once it's approved I need to initiate. Please let me know at your earliest convenience. Also could you please give a rough ETA for the merge to be completed. We will need this as soon as we can get it.