cohoe / starrs

System Technology Accounting and Resource Registration Solution
grantcohoe.com/projects/starrs
Other
16 stars 6 forks source link

fix $output lines in DB/API/DHCP/api_dhcp_utility.sql #86

Closed agargiulo closed 13 years ago

cohoe commented 13 years ago

As you debug, you may find "https://impulse.csh.rit.edu/output/view/dhcpd.conf" useful. I dont remember if I set the permissions on it so you might get permission denied. :/

On Tue, Aug 9, 2011 at 4:52 PM, agargiulo reply@reply.github.com wrote:

Reply to this email directly or view it on GitHub: https://github.com/cohoe/impulse/issues/86

Grant Cohoe

System Administrator, Computer Science House Applied Networking and System Administration Rochester Institute of Technology cohoe@csh.rit.edu | 330-790-1701

agargiulo commented 13 years ago

Oh, nice. Thanks. I almost have all the bugs worked out.

agargiulo commented 13 years ago

okay, can't figure this one out, maybe you can Cohoe. WARNING: Use of uninitialized value in concatenation (.) or string at line 232, <DATA> line 522. CONTEXT: PL/Perl function "generate_dhcpd_config" WARNING: Use of uninitialized value in concatenation (.) or string at line 112, <DATA> line 522. CONTEXT: PL/Perl function "generate_dhcpd_config"

cohoe commented 13 years ago

There were a few subs that you forgot to return $output.

Also, when there were no query results, it complained about $output from the sub being empty. I added a few lines of $output = ""; which will give $output an empty string value to give back, rather than NULL which it would complain about. See the commit for all details.

On Wed, Aug 10, 2011 at 1:40 AM, agargiulo reply@reply.github.com wrote:

uninitialized value in concatenation (.) or string at line 112, line 522.    CONTEXT:  PL/Perl function

Grant Cohoe

System Administrator, Computer Science House Applied Networking and System Administration Rochester Institute of Technology cohoe@csh.rit.edu | 330-790-1701

agargiulo commented 13 years ago

This has been fixed, just forgot to close the issue when I fixed it.