search

coi-gov-pl / rspec-puppet-facts-unsupported

Helpers to generate unsupported OS facts to test for proper fail
Other
1 stars 1 forks source link

Use downcase() only for fact sets which fact a valid operatingsystem #4

Open baurmatt opened 5 years ago

baurmatt commented 5 years ago

facterdb 0.8.1 introduced a SLES 15 SP1 fact set which doesn't have a operatingsystem fact. This is due to bugs in facter 2.5. As facter 2.5 doesn't get maintance anymore, we need to fail safely here.

Fixes #3.

baurmatt commented 5 years ago

Not sure why the 1.9 test fails. Pretty sure it's not because of my change.

cardil commented 5 years ago

I've checked out develop branch and runned bundle exec rake spec on Ruby 1.9 and all tests have passed.

It must be your change that breaks this test on Ruby 1.9.

baurmatt commented 5 years ago

Hey @cardil,

thanks for taking a look! :) I've altered the output as suggested and added a test.

Regarding the failing tests: I'm pretty sure the error isn't related because the latest commit in the develop branch throws the same error, but for Ruby 2.4. Also my just pushed commit makes Ruby 1.9 fail, but let Ruby 2.1 fail.

baurmatt commented 5 years ago

Hey @cardil could we get this merged and released? :)

baurmatt commented 4 years ago

Hey @cardil, any chance to get this merged and released? :)