Closed consp1racy closed 4 years ago
@colinrtwhite taking this over.
@mario Thanks, but I'd hold off for the moment (still debating if we should make this change). I generally agree that using numbers is more consistent, however Build.VERSION_CODES
seems like the standard.
@colinrtwhite sounds good.
Some of my favorite candidates for fix are in
RealBitmapPool
:Using actual API level values will promote readability, i.e. nobody will have to ponder for minutes why the hell do we check whether SDK_INT is less than, greater than or equal to zero.
See https://twitter.com/jakewharton/status/1049421501559128065 for discussion. Main points:
@RequiresApi(21)
,minSdkVersion 21
,setWhateverApiLevel(21)
.CAN_USE_THING_API_LEVEL = 21
.@RequiresApi
,@SdkSuppress
,Build.VERSION.SDK_INT
, and comments is less painful but not obvious.FINGERPRINT_ENABLED
.