coiled / dask-community

Issue tracker for the Dask community team
MIT License
2 stars 0 forks source link

[Discourse] Windows jobs failing on my Pull Request #1407

Open github-actions[bot] opened 2 years ago

github-actions[bot] commented 2 years ago

Hi,

I have opened a PR https://github.com/dask/dask/pull/9441 but my test keeps failing on the windows jobs. Could anybody please give me some help to work out why this is happening?

Thanks,

Alex

1 post - 1 pa…


Would you like to know more?

Read the full article on the following website:

https://dask.discourse.group/t/windows-jobs-failing-on-my-pull-request/1117

MaximLippeveld commented 2 years ago

As seen in your test output, the error seems to lie in different directory separators.

E   AssertionError: DataFrame.iloc[:, 2] (column name="path") are different
E   
E   DataFrame.iloc[:, 2] (column name="path") values are different (100.0 %)
E   [index]: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
E   [left]:  [C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file1.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file2.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file1.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file2.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file1.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file2.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file1.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file2.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file1.parquet, C:/Users/runneradmin/AppData/Local/Temp/pytest-of-runneradmin/pytest-0/popen-gw0/test_read_parquet_multiple_fil0/file2.parquet]
E   [right]: [C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file1.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file2.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file1.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file2.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file1.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file2.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file1.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file2.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file1.parquet, C:\Users\runneradmin\AppData\Local\Temp\pytest-of-runneradmin\pytest-0\popen-gw0\test_read_parquet_multiple_fil0\file2.parquet]

Left has unix-style forward slash, right has windows-style backward slash.

Since this is a windows test, left should also be windows-style backward slash. Left is produced by dd.read_parquet, maybe it can only return unix-style paths?