coiled / dask-mongo

BSD 3-Clause "New" or "Revised" License
19 stars 9 forks source link

Replace name of `read_partition` to include mongo #4

Closed ncclementi closed 3 years ago

ncclementi commented 3 years ago

When reading from mongo using read_mongo the low low-level functions that shows up on the task-stream plot in the dashboard is read_partitions . We want this to make a reference that is reading from a mongo database, therefore we should change the name.

One option could be fetch_mongo_partitions, but it seems long. Any suggestions?

jrbourbeau commented 3 years ago

Maybe just fetch_mongo? That might go well with the corresponding write_mongo function for writing a partition to mongo

ncclementi commented 3 years ago

I like that analogy, it makes sense.

jrbourbeau commented 3 years ago

Closed via https://github.com/coiled/dask-mongo/pull/2. Thanks @ncclementi