Closed jrbourbeau closed 1 year ago
LGTM, @jrbourbeau can you fix the linting issue?
Thanks @ncclementi. That unrelated linting failure should be fixed by https://github.com/coiled/dask-snowflake/pull/32
Also, let me see if I can add a quick test for the changes here...
I wasn't able to get my local snowflake setup working...let's see if this test passes in CI 🤞
Okay, this is good to go -- thanks @ncclementi
It's nice to see the rapid merging of small but important changes like this :)
On a call with @ncclementi today I noticed we're not using
arrow_options
when computingmeta
but we are when computing partitions. This could lead tometa
not being correct. This PR makes sure we usearrow_options
accordingly.