search

coiled / dask-snowflake

Dask integration for Snowflake
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Use `arrow_options` with computing `meta` #31

Closed jrbourbeau closed 1 year ago

jrbourbeau commented 1 year ago

On a call with @ncclementi today I noticed we're not using arrow_options when computing meta but we are when computing partitions. This could lead to meta not being correct. This PR makes sure we use arrow_options accordingly.

ncclementi commented 1 year ago

LGTM, @jrbourbeau can you fix the linting issue?

jrbourbeau commented 1 year ago

Thanks @ncclementi. That unrelated linting failure should be fixed by https://github.com/coiled/dask-snowflake/pull/32

Also, let me see if I can add a quick test for the changes here...

jrbourbeau commented 1 year ago

I wasn't able to get my local snowflake setup working...let's see if this test passes in CI 🤞

jrbourbeau commented 1 year ago

Okay, this is good to go -- thanks @ncclementi

mrocklin commented 1 year ago

It's nice to see the rapid merging of small but important changes like this :)