search

coiled / dask-snowflake

Dask integration for Snowflake
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Expose `on_error` in to_snowflake #50

Closed nick-amplify closed 5 months ago

nick-amplify commented 1 year ago

Hey Dask team,

Our team needed to use the on_error arg of write_pandas for our app, so I added it in here.

Lmk what steps I can/should follow to merge this into the official package!

nick-amplify commented 5 months ago

@jrbourbeau hey James! been awhile... but I got back around to this! changed to write_pandas_kwargs and the tests are passing!

jrbourbeau commented 5 months ago

I tried to merge main (where some test failures have been fixed) and push to this branch, but that somehow closed this PR...

Sorry about that @nick-amplify. I opened up https://github.com/coiled/dask-snowflake/pull/57 which has the same commits. Hope that's okay

nick-amplify commented 5 months ago

I tried to merge main (where some test failures have been fixed) and push to this branch, but that somehow closed this PR...

Sorry about that @nick-amplify. I opened up #57 which has the same commits. Hope that's okay

Yeah that's cool with me!