coiled / dask-snowflake

Dask integration for Snowflake
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Temporarily disable `log_telemetry_imported_packages` #52

Closed jrbourbeau closed 1 year ago

jrbourbeau commented 1 year ago

It so happens we can just disable the non-thread safe functionality in the Snowflake connector highlighted in https://github.com/coiled/dask-snowflake/issues/51.

I think turning it off by default (with a meaningful error message when a users explicit wants it on) as a temporary workaround for https://github.com/snowflakedb/snowflake-connector-python/issues/1648 makes sense.

@fjetter do you have bandwidth to review?

jrbourbeau commented 1 year ago

CI has run here 4 times successfully. I'm probably going to merge this in later today if nobody objects. Prohibiting this particular config option seems like it will have little impact of real-world users (the config option seems rather exotic?) while fixing the multithreading issue we've seen on main