coiled / dask-snowflake

Dask integration for Snowflake
BSD 3-Clause "New" or "Revised" License
29 stars 7 forks source link

Converting from HLG to from_map #60

Closed alex-rakowski closed 1 month ago

alex-rakowski commented 1 month ago

@phofl @fjetter

Replacing HLG with dd.from_map to enable dask_expr functionality. Reverts to existing method if dask version doesn't support from_map.

phofl commented 1 month ago

I think I would prefer just requiring a minimum version that definitely supports from_map

ntabris commented 1 month ago

I think I would prefer just requiring a minimum version that definitely supports from_map

What would this minimum version be?

phofl commented 1 month ago

Pinning to at least the first version that has Dask-Expr enabled would make sense

Users of older dask version would just pull the previous release

alex-rakowski commented 1 month ago

@phofl @jrbourbeau I think this is good to go, the failing tests c.f. deprecation of 3.7 and 3.8

phofl commented 1 month ago

Can you drop the ci jobs?

phofl commented 1 month ago

Ah sorry, just merge main and the failures will go away

phofl commented 1 month ago

And you'll have to update the minimum python version in setup.py

phofl commented 1 month ago

thx