Use ``threads_per_worker=-1`` for Coiled Functions

jrbourbeau commented 9 months ago

This is just a minor nit. Note it requires the latest coiled=0.9.36 release (pushed out about an hour ago)

review-notebook-app[bot] commented 9 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mrocklin commented 9 months ago

I propose that we hold off on this. The risk-reward don't seem worth it to me (someone will be using an old install)

On Thu, Oct 5, 2023 at 9:49 AM review-notebook-app[bot] < @.***> wrote:

Check out this pull request on [image: ReviewNB] https://app.reviewnb.com/coiled/examples/pull/38

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB https://www.reviewnb.com/?utm_source=gh

— Reply to this email directly, view it on GitHub https://github.com/coiled/examples/pull/38#issuecomment-1749064388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKZTAKJH4DGQOVCVUNVDDX53CJDAVCNFSM6AAAAAA5UMTPD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGA3DIMZYHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

https://coiled.io

Matthew Rocklin CEO, Dask Maintainer

jrbourbeau commented 9 months ago

Makes sense

coiled / examples

Use ``threads_per_worker=-1`` for Coiled Functions #38

See visual diffs & provide feedback on Jupyter Notebooks.