coiled / feedback

A place to provide Coiled feedback
14 stars 3 forks source link

Validators for AWS network names are wrong #161

Closed jmathes closed 2 years ago

jmathes commented 2 years ago

Describe the bug In cloud.coiled.io//account/update-backend-options, after providing AWS credentials and asking to use an existing VPC and network resources, the input field validators assume each id is 17 characters long, which is not necessarily true

Reference Links, optional There are slack threads in #general and #coiled-cloud

Issue Priority, optional

Environment, optional N/A; this is a bug with your website

Diagnostics, optional N/A; this is a bug with your website

Additional context the validators are regular expressions in src/pages/Account/UpdateOptions/AWS/index.tsx on line ~90: fieldValidations={{ networkId: /^vpc-[A-Fa-f0-9/]{17}$/, schedulerSubnetId: /^subnet-[A-Fa-f0-9/]{17}$/, workerSubnetId: /^subnet-[A-Fa-f0-9/]{17}$/, firewallId: /^sg-[A-Fa-f0-9/]{17}$/, schedulerFirewallId: /^sg-[A-Fa-f0-9/]{17}$/, }}

jmathes commented 2 years ago

There are likely server-side validators that are also incorrect

hayesgb commented 2 years ago

cc: @dchudz

dchudz commented 2 years ago

Joe: Sorry about this, and thanks for pointing it out.

Internal issue: https://gitlab.com/coiled/cloud/-/issues/4943

jmathes commented 2 years ago

Thanks. This is preventing us from productionizing a system that pays you money :)

0-ren commented 2 years ago

Hey @jmathes

While we're working on fixing this, I'd love to talk more about your use case, get you some more special attention, and figure out how we can make your life easier. And get that productionizing popping asap.

Are you free sometime this week to talk? Here's a link to my calendar where you can find a time that works best for you.

Thanks!

jmathes commented 2 years ago

Is there any chance I could get an ETA on this? It's a blocker and it'll affect our internal planning

dchudz commented 2 years ago

@jmathes We expect to have the fix deployed today.

Sorry about not being in touch earlier with timelines.

dchudz commented 2 years ago

@jmathes I also wanted to mention coiled.set_backend_options which you could use as an alternative to the UI. (Some of our users prefer configuring things with code, and this should also sidestep the validation since we aren't checking lengths server-side.)

dchudz commented 2 years ago

@jmathes We've deployed the fix.

jmathes commented 2 years ago

Thanks so much!