search

coiled / feedback

A place to provide Coiled feedback
14 stars 3 forks source link

ignore_local_packages in coiled.create_software_environment is ignored #270

Closed seanv507 closed 9 months ago

seanv507 commented 9 months ago

in version 1.3.10, core.py lines 836-841

if include_local_code:
                prefix = await scan_prefix()
                packages, _ = partition_ignored_packages(
                    prefix, {(k, "pip"): PackageLevelEnum.IGNORE for k in ignore_local_packages}
                )
                packages, local_packages = partition_local_python_code_packages(prefix)

I think last line should be

packages, local_packages = partition_local_python_code_packages(packages)

otherwise the packages filtering out ignored packages is overwritten

dan-blanchard commented 9 months ago

Thanks for catching and reporting this! We'll have a new version with this fix out soon.