coiled / feedback

A place to provide Coiled feedback
14 stars 3 forks source link

Error when creating environment from YAML with pip packages #28

Closed jose-moralez closed 4 years ago

jose-moralez commented 4 years ago

Hi. When trying to create an environment from a YAML file with pip packages in it I get the following error:

> coiled.create_software_environment(name='myenv', conda='env.yml')
Updating Software Environment ... -
{"message": "Solving conda environment..."}  
{"message": "Failed:\n\nInvalid spec 'None': Cannot match on field(s): {'pip'}"}  
{"message": "Invalid spec 'None': Cannot match on field(s): {'pip'}", "raise": true}  

I've used the helm chart before and I remember they were two different fields (conda packages and pip packages) not sure if this is related.

Here is the environment file I was using:

name: myenv
channels:
  - conda-forge
  - defaults
dependencies:
  - python=3.7
  - dask
  - lightgbm
  - numpy
  - pandas
  - pip
  - scikit-learn
  - statsmodels
  - pip:
    - arch
    - supersmoother
mrocklin commented 4 years ago

Thanks for raising this issue @jose-moralez .

I believe that @jrbourbeau already has a fix for it that will go out with the next release. (is that right @jrbourbeau ?)

jrbourbeau commented 4 years ago

Yep, that's correct!

@jose-moralez support for pip package within a conda environment YAML file will be included in the next release

jose-moralez commented 4 years ago

Thank you for your quick response. I came across this issue on friday and checked the docs just now and saw the pip keyword argument in the create_software_environment method, I closed this after that because it solves my problem. However I see that it's not included in version 0.0.15, is that part of the next release?

jrbourbeau commented 4 years ago

is that part of the next release?

Yes, both the pip= keyword for create_software_environment and pip packages within a conda environment file are part of the next release. With coiled==0.0.15 only conda packages and docker images are supported for creating software environments. I can be sure to ping you on this issue when we push out the next release : )

mrocklin commented 4 years ago

Yes :)

On Mon, Jul 27, 2020 at 10:08 AM capybara notifications@github.com wrote:

Thank you for your quick response. I came across this issue on friday and checked the docs just now and saw the pip keyword argument in the create_software_environment method, I closed this after that because it solves my problem. However I see that it's not included in version 0.0.15, is that part of the next release?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/coiled/coiled-issues/issues/28#issuecomment-664521925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKZTBGLXY3CXNZKSG4EKLR5WYAFANCNFSM4PI6YHTQ .

jose-moralez commented 4 years ago

Great. Thank you!

jrbourbeau commented 4 years ago

@jose-moralez we pushed out coiled==0.0.16 earlier today, so you should be good to upgrade and start using pip packages!