search

coiled / feedback

A place to provide Coiled feedback
14 stars 3 forks source link

Edit cluster configurations #32

Closed mrocklin closed 3 years ago

mrocklin commented 4 years ago

We should turn back on editing of cluster configurations.

cc @dantheman39

selshowk commented 4 years ago

Not sure if this is what is meant by this issue but I've noticed that calling create_cluster_configuration with an existing configuration name does not fail but nor does it update the configuration. This is pretty confusing (I thought I was trying a bunch of different configs but it turns out it was always the same one..) so I propose throwing an error if we don't support an update.

mrocklin commented 4 years ago

Hrm, yes I can see how that would be frustrating.

The intention today is that it overwrites.

On Fri, Aug 21, 2020 at 7:01 AM sheer-coiled notifications@github.com wrote:

Not sure if this is what is meant by this issue but I've noticed that calling create_cluster_configuration with an existing configuration name does not fail but nor does it update the configuration. This is pretty confusing (I thought I was trying a bunch of different configs but it turns out it was always the same one..) so I propose throwing an error if we don't support an update.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/coiled/coiled-issues/issues/32#issuecomment-678305816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKZTCR5KE3P2E7YREAWLLSBZ4ZZANCNFSM4PQ3DGQQ .

FabioRosado commented 3 years ago

We have recently fixed the issue where updating a cluster configuration wouldn't update the software environment field if being passed. We also talked about this issue, it seems that we want users to edit their cluster configuration.

I'm closing this issue, unless you think the cluster configuration shouldn't be edited? Please reopen the issue if we should talk or modify the behaviour of our create_cluster_configuration