search

coilysiren / todo

various project / TODO list ideas
0 stars 0 forks source link

sirupsen/logrus/issues/959 #2

Open coilysiren opened 5 years ago

coilysiren commented 5 years ago

https://github.com/sirupsen/logrus/issues/959

https://github.com/sirupsen/logrus/pull/977

coilysiren commented 5 years ago

blocked by https://github.com/lynncyrin/base-image/issues/18

coilysiren commented 5 years ago

This is done 🎉 but people mentioned in code review (https://github.com/sirupsen/logrus/pull/977#discussion_r298289717) that some parts of the code could be restructured - so I'll create a followup PR that addresses that