improve cl wrapper - Githubissues

coin-or-tools / BuildTools

Macros and patches for GNU autotools

https://coin-or-tools.github.io/BuildTools/

Other

3 stars 7 forks source link

improve cl wrapper #111

Closed svigerske closed 5 years ago

svigerske commented 5 years ago

Issue created by migration from Trac.

Original creator: @svigerske

Original creation time: 2018-10-17 15:24:23

Assignee: @svigerske

Keywords: autotools-update

Regarding Automake/compile or cccl:

-EHsc should always(?) be added to compiler flags
-g should be mapped to -Zi (or similar)

svigerske commented 5 years ago

Comment by @svigerske created at 2018-10-17 15:40:13

Changing status from new to assigned.

svigerske commented 5 years ago

Comment by @svigerske created at 2018-10-17 19:55:38

If running configure with --enable-msvc, we actually change the default CXXFLAGS to include -EHsc.

svigerske commented 5 years ago

I don't think that I'll still do anything here.

As said, the default compiler flags in coin.m4 already include -EHsc if in MSVC-mode. It's probably better to have this done via CXXFLAGS, so a user can modify, instead of hardcoding this into the compile script. Also the latter probably doesn't which language (C, C++, Fortran) is compiled.

Further, we now pass -Zi if --enable-debug is set.