search

coin-or-tools / BuildTools

Macros and patches for GNU autotools
https://coin-or-tools.github.io/BuildTools/
Other
3 stars 7 forks source link

[0.8] Fix clang with an absolute path being misidentified as cl in coin.m4 #153

Closed valgur closed 2 months ago

valgur commented 2 months ago

Using Clang as $CC or $CXX with an absolute path breaks ./configure due to it being misclassified as cl in many places.

Notably, it causes the linker to be set as link instead of ld, which in turn causes the SONAME property in .so files to not be set and the library to be referenced only via full paths in the .dynamic section when linked against.

There's one spot currently that handled it correctly: https://github.com/coin-or-tools/BuildTools/blob/releases/0.8.11/coin.m4#L327 I applied the same logic to all other locations in coin.m4.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

svigerske commented 2 months ago

Thank you. Is there a particular COIN-OR project where you need this to be applied?

valgur commented 2 months ago

Thanks! I'm mostly interested in Osi and Clp currently, personally. I've already applied the patch in the package repo I'm using (https://github.com/valgur/conan-center-index/commit/5bf1cb6a04fbce38a9c37a8f510227236875898f), so I'm no longer affected by this, though.