search

coin-or / Bcp

Branch-Cut-Price Framework
Other
26 stars 13 forks source link

`make distclean' leaves behind files/directories and erronously removes Bcp/examples #14

Closed svigerske closed 5 years ago

svigerske commented 5 years ago

Issue created by migration from Trac.

Original creator: awasielak

Original creation time: 2008-02-23 20:43:42

Assignee: somebody

Version:

Bcp version 1.1.2

Running `make distclean' leaves behind the following files/directories:

Bcp/test/BAC/bac.lp
Bcp/test/BAC/bac.mps
Bcp/test/BAC/bac.pdf
Bcp/test/BAC/bb.par
Bcp/test/BAC/include
Bcp/test/BAC/LP
Bcp/test/BAC/Member
Bcp/test/BAC/TM

It also erroneously removes Bcp/examples directory. If you try to run `./configure' again, it will fail:

[snip]
config.status: error: cannot find input file: examples/BAC/Makefile.in
configure: error: /bin/bash './configure' failed for Bcp

Here is a patch to fix the latter problem:

diff -urNad coinor-coinall-1.0.0~/Bcp/Makefile.am coinor-coinall-1.0.0/Bcp/Makefile.am
--- coinor-coinall-1.0.0~/Bcp/Makefile.am       2007-02-02 08:48:04.000000000 -0700
+++ coinor-coinall-1.0.0/Bcp/Makefile.am        2008-02-23 12:50:33.000000000 -0700
`@``@` -86,7 +86,6 `@``@`
        for t in $(TESTS); do \
                (if test -r test/$$t/Makefile; then cd test/$$t; $(MAKE) distclean; fi); \
        done
-       rm -rf examples

 .PHONY: test unitTest

diff -urNad coinor-coinall-1.0.0~/Bcp/Makefile.in coinor-coinall-1.0.0/Bcp/Makefile.in
--- coinor-coinall-1.0.0~/Bcp/Makefile.in       2007-12-08 11:22:25.000000000 -0700
+++ coinor-coinall-1.0.0/Bcp/Makefile.in        2008-02-23 12:50:33.000000000 -0700
`@``@` -843,7 +843,6 `@``@`
        for t in $(TESTS); do \
                (if test -r test/$$t/Makefile; then cd test/$$t; $(MAKE) distclean; fi); \
        done
-       rm -rf examples

 .PHONY: test unitTest
svigerske commented 5 years ago

Comment by ladanyi created at 2008-09-22 13:27:01

Problem (both parts) fixed.

svigerske commented 5 years ago

Comment by ladanyi created at 2008-09-22 13:27:01

Resolution: fixed

svigerske commented 5 years ago

Comment by awasielak created at 2009-02-11 01:33:31

Bcp version 1.2.1

There are still some directories that should get removed by `make distclean':

Bcp/test/BAC/TM
Bcp/test/BAC/Member
Bcp/test/BAC/LP
Bcp/test/BAC/include

Thanks,

Aramian

svigerske commented 5 years ago

Comment by awasielak created at 2009-02-11 01:33:31

Resolution changed from fixed to

svigerske commented 5 years ago

Comment by awasielak created at 2009-02-11 01:33:31

Changing status from closed to reopened.

svigerske commented 5 years ago

Comment by ladanyi created at 2009-06-05 03:46:45

Resolution: fixed