search

coin-or / CHiPPS-ALPS

This is the Abstract Library for Parallel Search (ALPS), the abstract base layer of the COIN-OR High Performance Parallel Search framework.
Eclipse Public License 1.0
9 stars 8 forks source link

fix potential memory leak #27

Closed yuxies closed 2 years ago

yuxies commented 2 years ago

Comment off lines based on Valgrind warning messages.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

tkralphs commented 2 years ago

In general, it's good practice to make a separate branch for each PR, but otherwise, looks good. We could probably just delete this code rather than commenting it. In some cases, it can make sense to retain the old code to get a quick reminder of what was changed when debugging in the future, but this one seem straightforward enough to just go ahead and delete. Remember that the whole point of having version control is that the old version is always there i to look back at. Anyway, just to get this done, I'll accept this PR, just commenting for the future.