search

coin-or / CyLP

A Python interface to CLP, CBC, and CGL to solve LPs and MIPs.
Other
182 stars 69 forks source link

Replace Coin{Max,Min} by std::{max,min} #201

Closed a-andre closed 3 months ago

tkralphs commented 3 months ago

The failures here have nothing to do with the PR, as far as I can see. The problem is that the build of Cbc is not even being started. There are some very strange errors, such as the apt-get command not being found and eventually, the coinbrew command also not being found, thus Cbc is not built. I spent a good amount of time digging around and I just cannot see what is going on here yet. The PR looks fine and I'm sure has nothing to do with this, but we should try to fix these errors before merging.

tkralphs commented 3 months ago

Now that we have this PR merged and all the builds (including the new arm64 ones) seem to finally be working, I'm planning to push out a new release (after doing releases of the Cbc stack). Let me know if there's more that you plan to do that I should wait on.

a-andre commented 3 months ago

Go ahead.