Closed spoorendonk closed 8 months ago
OK, I see that you do have methods here for setting callbacks C-style. And yes, both of the points you mentioned here have long been on my TODO list!
The callback sneaked in there. I was playing around with the implementation. It should not be part of this PR but added when we have resolve #109
Given my current time and effort I would be happy if we could agree on this version of the c interface for now. It can be expanded when the OsiSolverInterface is implemented, but for now I am little reluctant open up that issue - I think it should be an issue by itself?
For renaming Decomp -> Dip prefix should also be done elsewhere. For now I could rename these files to Decomp to be consistent?
I am unable to figure out why the AppVeyor build fails...
OK, sure, I don't want to hold you up with a long discussion of details. I'm happy if you move ahead with this and we can put off the OsiSolverInterface implementation until later. Perhaps we can open an issue to keep track of it. And sure, naming with Decomp
for now makes sense. We can change Decomp to Dip en masse at some later point, probably when moving to a new stable so that it doesn't matter if things break.
I renamed the files. I will add an example later
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
This is a suggestion for a minimum C interface for using Dip. This allows easy integration with other languages etc.
Then the user can do:
This was the easy option using the current classes and way of setting stuff up. My idea was just to expand the interface when needed but keeping it a very thin wrapper.
Some thoughts: