search

coin-or / OS

Optimization Services
Other
1 stars 4 forks source link

Dangling pointer in OSnl2osil #49

Open svigerske opened 5 years ago

svigerske commented 5 years ago

Issue created by migration from Trac.

Original creator: walter

Original creation time: 2011-12-29 12:35:19

Version:

In OSnl2osil's constructor has the following:

stub = &nlfilename[ 0];
nl = jac0dim(stub, (fint)strlen(stub));

Where nlfilename is passed by value and so it will be destroyed on exit from the c'tor (leaving stub dangling.)

One solution is to remove the unused member and simplify the c'tor to:

nl = jac0dim(nlfilename.c_str(), (fint)nlfilename.length());
svigerske commented 5 years ago

Comment by JunMa created at 2015-03-13 17:56:34

Sorry for the late reply. Do you still encounter the same issue?