GAMS parsing improvements

coin-or / SHOT

A solver for mixed-integer nonlinear optimization problems

https://shotsolver.dev

Eclipse Public License 2.0

117 stars 25 forks source link

GAMS parsing improvements #150

Closed andreaslundell closed 2 years ago

andreaslundell commented 2 years ago

Improvements to conversion of GAMS -> SHOT models: Simplification of sums of sums and products of products so they are combined into one sum/products; this fixes some crashes on large instances (e.g. autocorr*).

svigerske commented 2 years ago

I overlooked a wrong std::move introduced with this PR, fixed by c9bc78df94 on master. Wasn't a problem with GCC, but with MSVC we got segfaults. What a wonderful printf-debug session this was to find the problematic piece of code...

andreaslundell commented 2 years ago

Thanks, that was really an awful bug. Never understimate printf :-)