coin-or / jorlib

Java Operations Research Library
GNU Lesser General Public License v2.1
64 stars 37 forks source link

Compile error in Eclipse due to an incomplete looking exclude #7

Closed marotig closed 8 years ago

marotig commented 8 years ago

Joris, There is potential minor glitch in the maven scripts. pom.xml in the root directory excludes /org/jorlib/frameworks/columnGeneration/tsp//*. Eclipse respects this wish, but then AllFrameworksTests.java fails to compile due to a broken import. Nota bene, IntelliJ appears to ignore the exclude line. I can't tell whether it's an Eclipse issue, an IntelliJ issue, an issue in any of the maven plugins or simply a user error. Still, it looks likely that AllFrameworksTests is to be excluded once columnGeneration/tsp was excluded. Regards, Gabor

jkinable commented 8 years ago

Hm, I cannot remember why I included that line. I'll comment it out until I figure out why we need/don't need that. I tested: -eclipse -Intellij -mvn 3: mvn test

Eclipse indeed reports an error for AllFrameworksTest.java. Commenting out the exclude seems to fix this. Both Intellij and the mvn 3 tool simply seemed to ignore the exclude. Not sure why. Perhaps it has something to do with the surefire plugin.

On Thu, Jun 30, 2016 at 9:37 AM, marotig notifications@github.com wrote:

Joris, There is potential minor glitch in the maven scripts. pom.xml in the root directory excludes /org/jorlib/frameworks/columnGeneration/tsp//*. Eclipse respects this wish, but then AllFrameworksTests.java fails to compile due to a broken import. Nota bene, IntelliJ appears to ignore the exclude line. I can't tell whether it's an Eclipse issue, an IntelliJ issue, an issue in any of the maven plugins or simply a user error. Still, it looks likely that AllFrameworksTests is to be excluded once columnGeneration/tsp was excluded. Regards, Gabor

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jkinable/jorlib/issues/7, or mute the thread https://github.com/notifications/unsubscribe/ACnYyp1Vu3FQxwuUV0nbE0O-GdoP_Z7Iks5qQ8a2gaJpZM4JCKu- .

marotig commented 8 years ago

Hallo Joris, Thanks for the quick fix. G.