search

coin-or / python-mip

Python-MIP: collection of Python tools for the modeling and solution of Mixed-Integer Linear programs
Eclipse Public License 2.0
525 stars 92 forks source link

Windows CI/CD #111

Closed bonelli closed 2 years ago

bonelli commented 4 years ago

Here is a PR with Travis configured for Windows testing and 1 non-regression test of a particular case where Windows and MacOS crash

I'm not really interested in maintaining this non-regression test on the log run, it is there to investigate the issue.

jurasofish commented 4 years ago

Good stuff, would it be worth getting rid of the appveyor testing if windows can be used with travis?

h-g-s commented 4 years ago

Good stuff, would it be worth getting rid of the appveyor testing if windows can be used with travis?

Yes ! Appveyor takes longer to start tests. Only Travis would be easier to maintain. It seems that github now offers CI, but no idea on how to use it.

jurasofish commented 4 years ago

Yes ! Appveyor takes longer to start tests. Only Travis would be easier to maintain. It seems that github now offers CI, but no idea on how to use it.

I was thinking of suggesting moving to it. Using github CI has the benefit that forks will automatically run tests - no need to configure travis. Has windows, linux, and mac, and it's unlimited for public repos.

I've worked with it a bit, I can have a go at setting it up if you'd like? Should be a pretty easy switch given all the scripts and configs are already established for travis and appveyor.

h-g-s commented 4 years ago

It would be great to have the tests in github itself. It seems that we can even run longer tests. If you could do it would be great.

On Thu, 28 May 2020 at 21:23, Michael Jurasovic notifications@github.com wrote:

Yes ! Appveyor takes longer to start tests. Only Travis would be easier to maintain. It seems that github now offers CI, but no idea on how to use it.

I was thinking of suggesting moving to it. Using github CI has the benefit that forks will automatically run tests - no need to configure travis. Has windows, linux, and mac, and it's unlimited for public repos.

I've worked with it a bit, I can have a go at setting it up if you'd like? Should be a pretty easy switch given all the scripts and configs are already established for travis and appveyor.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/coin-or/python-mip/pull/111#issuecomment-635686413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4VZORAUEE5WDBFF534L7DRT36BLANCNFSM4NNOLHIA .

--

Haroldo Gambini Santos Computing Department Universidade Federal de Ouro Preto - UFOP email: haroldo@ufop.edu.br home/research page: www.decom.ufop.br/haroldo

It has long been an axiom of mine that the little things are infinitely the most important. -- Sir Arthur Conan Doyle, "A Case of Identity"

jurasofish commented 4 years ago

This has gone a little stale - is there any chance of at the very least merging the regression test? Always good to have more diverse tests.

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

:white_check_mark: bonelli
:white_check_mark: jurasofish
:x: tuliotoffolo
:x: h-g-s
You have signed the CLA already but the status is still pending? Let us recheck it.

bonelli commented 4 years ago

This has gone a little stale - is there any chance of at the very least merging the regression test? Always good to have more diverse tests.

I lost track of the advancements but I'd really appreciate python-mip to work in my case on Windows. What shall I do to quicken that?

sebheger commented 2 years ago

@jurasofish @bonelli Is there something which could be "rescued" to the latest master? Or could we close this PR?

jurasofish commented 2 years ago

I think these are the two relevant commits re the regression test, could put them in a new PR and see how it goes.

but windows testing is all sorted now from #113 I think

sebheger commented 2 years ago

@jurasofish Would appreciate if you do so

sebheger commented 2 years ago

@jurasofish Have you achieved any progress here?

sebheger commented 2 years ago

Discussion is continued in #269