search

coin-or / python-mip

Python-MIP: collection of Python tools for the modeling and solution of Mixed-Integer Linear programs
Eclipse Public License 2.0
525 stars 92 forks source link

GitHub actions #113

Closed jurasofish closed 4 years ago

jurasofish commented 4 years ago

Use github actions for testing and format checking. This is a trial in my mind - I propose leaving travis and appveyor in place for now until we're happy with actions and we can make a decision to switch over or not.

Related to conversation in #111

I've also added pypy in, which required skipping the matplotlib test. And python 3.5 on MacOS required a different matplotlib backend to work (https://github.com/uber/ludwig/issues/114 and https://github.com/uber/ludwig/commit/6b948ea9f0b2e78558fb51d2edd4d9c3558ff505)

Benefits of github actions

h-g-s commented 4 years ago

Great ! One thing: after modifying plant_location.py, please upgrade in the documentation (examples.rst) which lines of the example should be displayed in the documentation. The search for matplotlib could be included before everything and hidden in the docs, so the example would not be very polluted. Also, the last lines are for sanity checks.

jurasofish commented 4 years ago

all done, thanks for pointing that out

h-g-s commented 4 years ago

Really impressed on how fast these tests runs!!! Having pypy in the tests is also really great, thanks !

jurasofish commented 4 years ago

no worries!