Closed pabloazurduy closed 3 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: pabloazurduy
:x: Pablo Azurduy
Hello Pablo !
Hi guys, Some known issues:
- I implement the constraint importance as a property on the Constraint Class, this seems to not be ideal, what do you guys think? I understand that @h-g-s wants to use a
np.array
or alist
but not sure how to implement that.
No problem, in the first implementation it can be stored as a property in Constraint and we can move it after to a more efficient storage.
- Also, we need to document this new features. I don't know where or how.
I'll generate the documentation and see what is missing.
- The iterative process in IIS and in the relaxer has a huge log output because of the iterative nature and the Mode.solve() standard output. That shows a lot of unuseful logs that are not easy or understandable to read.
It would be good to remove some unnecessary logs. I think that, besides the final message, intermediate messages should only appear after some time without printing messages (e.g. one second).
- The test is mostly completed for the conflict.class, but it might be a little bit basic.
Great, thanks! BTW, There is a message in the pull request saying that you have to sign the contributor license agreement, could you check it ?
Cheers
Thanks ! Pablo
Hi guys, Some known issues:
np.array
or alist
but not sure how to implement that.Thanks ! Pablo